From 87c6fcc786c7eb6a87d82cdbe9376ed08546726f Mon Sep 17 00:00:00 2001 From: Mr-X-GTA <110748953+Mr-X-GTA@users.noreply.github.com> Date: Fri, 10 Jan 2025 09:33:59 +0100 Subject: [PATCH] fix --- src/backend/backend.cpp | 3 ++ src/backend/commands/player/kick/battleye.cpp | 46 ++++++++++++++++++- src/gta_pointers.hpp | 3 ++ src/hooking/hooking.cpp | 2 + src/hooking/hooking.hpp | 2 + .../protections/add_skeleton_extension.cpp | 15 ++++++ src/hooks/protections/received_event.cpp | 25 ++++++++-- .../protections/script_event_handler.cpp | 2 +- src/pointers.cpp | 11 +++++ src/services/gta_data/gta_data_service.cpp | 3 ++ src/views/players/player/player_kick.cpp | 4 ++ 11 files changed, 109 insertions(+), 7 deletions(-) create mode 100644 src/hooks/protections/add_skeleton_extension.cpp diff --git a/src/backend/backend.cpp b/src/backend/backend.cpp index 004a6542..fd8d2f2d 100644 --- a/src/backend/backend.cpp +++ b/src/backend/backend.cpp @@ -21,6 +21,9 @@ namespace big { void bypass_battleye() { + if (g.spoofing.spoof_game_data_hash) + return; + constexpr std::array valid_hashes = {4022154788, 988, 3512952254, 472, 0, 0, 3308328917, 0, 0, 1731098795, 2256610353, 18616, 1540917665, 307143837, 1629784955, 2012170620}; if (auto hashes = *g_pointers->m_gta.m_game_data_hash) diff --git a/src/backend/commands/player/kick/battleye.cpp b/src/backend/commands/player/kick/battleye.cpp index bae9eba2..eeca1812 100644 --- a/src/backend/commands/player/kick/battleye.cpp +++ b/src/backend/commands/player/kick/battleye.cpp @@ -27,11 +27,55 @@ namespace big msg.write(KickReason::BATTLEYE_KICK, 5); msg.write(0, 32); msg.write(false, 1); - auto msg_id = player->get_session_player()->m_msg_id; msg.send(msg_id); } }; + class battleye_ban : player_command + { + using player_command::player_command; + + virtual CommandAccessLevel get_access_level() override + { + return CommandAccessLevel::TOXIC; + } + + virtual void execute(player_ptr player, const command_arguments& _args, const std::shared_ptr ctx) override + { + packet msg{}; + + msg.write_message(rage::eNetMessage::MsgKickPlayer); + msg.write(KickReason::BATTLEYE_BAN, 5); + msg.write(0, 32); + msg.write(false, 1); + auto msg_id = player->get_session_player()->m_msg_id; + msg.send(msg_id); + } + }; + + class battleye_update_kick : player_command + { + using player_command::player_command; + + virtual CommandAccessLevel get_access_level() override + { + return CommandAccessLevel::TOXIC; + } + + virtual void execute(player_ptr player, const command_arguments& _args, const std::shared_ptr ctx) override + { + unsigned char data[] = {0x00, 0x50, 0x31, 0x4A, 0xC0, 0x1A, 0x13, 0xFF, 0xFF, 0xFF}; + player->tampered_with_be = true; + for (int i = 0; i < 20; i++) + { + data[0] = i; + g_battleye_service.send_message_to_client(player->get_net_game_player()->get_host_token(), &data, sizeof(data)); + } + } + }; + battleye_kick g_battleye_kick("battlekick", "BATTLEYE_KICK", "BATTLEYE_KICK_DESC", 0); + battleye_ban g_battleye_ban("battleban", "BATTLEYE_FAKE_BAN", "BATTLEYE_FAKE_BAN_DESC", 0); + battleye_update_kick g_battleye_update_kick("battleupdate", "BATTLEYE_UPDATE_KICK", "BATTLEYE_UPDATE_KICK_DESC", 0); } \ No newline at end of file diff --git a/src/gta_pointers.hpp b/src/gta_pointers.hpp index 1a5c871e..dd1ce290 100644 --- a/src/gta_pointers.hpp +++ b/src/gta_pointers.hpp @@ -408,6 +408,9 @@ namespace big PVOID m_network_can_access_multiplayer; PVOID m_be_network_bail_patch; + + PVOID m_add_skeleton_extension; + int* m_skeleton_extension_count; }; #pragma pack(pop) static_assert(sizeof(gta_pointers) % 8 == 0, "Pointers are not properly aligned"); diff --git a/src/hooking/hooking.cpp b/src/hooking/hooking.cpp index 64489c53..86168de2 100644 --- a/src/hooking/hooking.cpp +++ b/src/hooking/hooking.cpp @@ -157,6 +157,8 @@ namespace big detour_hook_helper::add("NCAM", g_pointers->m_gta.m_network_can_access_multiplayer); + detour_hook_helper::add("ASE", g_pointers->m_gta.m_add_skeleton_extension); + g_hooking = this; } diff --git a/src/hooking/hooking.hpp b/src/hooking/hooking.hpp index c1e91972..f6381edd 100644 --- a/src/hooking/hooking.hpp +++ b/src/hooking/hooking.hpp @@ -212,6 +212,8 @@ namespace big static void* create_pool_item(GenericPool* pool); static uint32_t network_can_access_multiplayer(uint32_t a1, uint64_t* a2); + + static void* add_skeleton_extension(rage::fwEntity* entity); }; class minhook_keepalive diff --git a/src/hooks/protections/add_skeleton_extension.cpp b/src/hooks/protections/add_skeleton_extension.cpp new file mode 100644 index 00000000..4d8ddd57 --- /dev/null +++ b/src/hooks/protections/add_skeleton_extension.cpp @@ -0,0 +1,15 @@ +#include "hooking/hooking.hpp" +#include "pointers.hpp" + +namespace big +{ + void* hooks::add_skeleton_extension(rage::fwEntity* entity) + { + if (*g_pointers->m_gta.m_skeleton_extension_count >= 32) [[unlikely]] + { + return nullptr; + } + + return g_hooking->get_original()(entity); + } +} \ No newline at end of file diff --git a/src/hooks/protections/received_event.cpp b/src/hooks/protections/received_event.cpp index b7c9552d..b5c9b617 100644 --- a/src/hooks/protections/received_event.cpp +++ b/src/hooks/protections/received_event.cpp @@ -267,7 +267,7 @@ namespace big return false; } - void scan_explosion_event(CNetGamePlayer* player, rage::datBitBuffer* buffer) + bool scan_explosion_event(CNetGamePlayer* player, rage::datBitBuffer* buffer) { uint16_t f186; uint16_t targetEntity; @@ -302,6 +302,8 @@ namespace big uint32_t f164; + uint32_t interiorIndex; + float posX224; float posY224; float posZ224; @@ -345,6 +347,8 @@ namespace big f191 = buffer->Read(1); f164 = buffer->Read(32); + interiorIndex = buffer->Read(32); + if (f242) { posX224 = buffer->ReadSignedFloat(31, 27648.0f); @@ -358,10 +362,14 @@ namespace big posZ224 = 0; } - auto f168 = buffer->Read(32);// >= 1868: f_168 - - f240 = buffer->Read(1); + + if (addOwnedExplosion) + { + buffer->Read(32); + buffer->Read(32); + } + if (f240) { f218 = buffer->Read(16); @@ -374,6 +382,12 @@ namespace big buffer->Seek(0); + if (*(int16_t*)&interiorIndex < -1) + { + notify::crash_blocked(player, "invalid interior"); + return true; + } + auto object = g_pointers->m_gta.m_get_net_object(*g_pointers->m_gta.m_network_object_mgr, ownerNetId, true); auto entity = object ? object->GetGameObject() : nullptr; @@ -391,7 +405,7 @@ namespace big reinterpret_cast(entity)->m_player_info->m_net_player_data.m_name))); session::add_infraction(g_player_service->get_by_id(player->m_player_id), Infraction::BLAME_EXPLOSION_DETECTED); LOGF(stream::net_events, WARNING, "{} sent an EXPLOSION_EVENT with addOwnedExplosion enabled and with the wrong owner", player->get_name()); - return; + return true; } if (g.session.explosion_karma && g_local_player @@ -403,6 +417,7 @@ namespace big }); } + return false; // clang-format on } diff --git a/src/hooks/protections/script_event_handler.cpp b/src/hooks/protections/script_event_handler.cpp index 56b90923..e3f59025 100644 --- a/src/hooks/protections/script_event_handler.cpp +++ b/src/hooks/protections/script_event_handler.cpp @@ -440,7 +440,7 @@ namespace big } case eRemoteEvent::StartScriptBegin: { - auto script_id = args[3]; + int script_id = args[3]; if (!protection::should_allow_script_launch(script_id)) { diff --git a/src/pointers.cpp b/src/pointers.cpp index b47fa6f9..193dee26 100644 --- a/src/pointers.cpp +++ b/src/pointers.cpp @@ -1914,6 +1914,17 @@ namespace big { g_pointers->m_gta.m_be_network_bail_patch = ptr.add(17).rip().add(1).rip().as(); } + }, + // Add Skeleton Extension + { + "ASE", + "E8 ? ? ? ? 48 89 44 24 ? 48 85 C0 0F 84 ? ? ? ? 0F 28 05", + [](memory::handle ptr) + { + ptr = ptr.rip(); + g_pointers->m_gta.m_add_skeleton_extension = ptr.as(); + g_pointers->m_gta.m_skeleton_extension_count = ptr.add(0x2C).rip().as(); + } } >(); // don't leave a trailing comma at the end diff --git a/src/services/gta_data/gta_data_service.cpp b/src/services/gta_data/gta_data_service.cpp index ed99eeea..24ec1776 100644 --- a/src/services/gta_data/gta_data_service.cpp +++ b/src/services/gta_data/gta_data_service.cpp @@ -429,6 +429,9 @@ namespace big const auto name = item.child("Name").text().as_string(); const auto hash = rage::joaat(name); + if (hash == "WEAPON_STRICKLER"_J) // Gen9 exclusive + continue; + if (hash == "WEAPON_BIRD_CRAP"_J) continue; diff --git a/src/views/players/player/player_kick.cpp b/src/views/players/player/player_kick.cpp index 51c0ebbe..6f19bdd1 100644 --- a/src/views/players/player/player_kick.cpp +++ b/src/views/players/player/player_kick.cpp @@ -15,6 +15,10 @@ namespace big components::player_command_button<"breakup">(g_player_service->get_selected()); ImGui::SameLine(); components::player_command_button<"battlekick">(g_player_service->get_selected()); + ImGui::SameLine(); + components::player_command_button<"battleban">(g_player_service->get_selected()); + ImGui::SameLine(); + components::player_command_button<"battleupdate">(g_player_service->get_selected()); ImGui::EndDisabled(); components::player_command_button<"smartkick">(g_player_service->get_selected());