From 675548770c5876ca6dc648f9efdeeb7d90b1cc73 Mon Sep 17 00:00:00 2001 From: Aure7138 <100095051+Aure7138@users.noreply.github.com> Date: Fri, 2 Dec 2022 02:37:58 +0800 Subject: [PATCH] chore(Received Event): Rename variables with accurate names (#653) --- src/hooks/protections/received_event.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/hooks/protections/received_event.cpp b/src/hooks/protections/received_event.cpp index 2b1902a3..d8af1d3c 100644 --- a/src/hooks/protections/received_event.cpp +++ b/src/hooks/protections/received_event.cpp @@ -194,7 +194,7 @@ namespace big uint32_t unk = buffer->Read(32); if (type == ScriptEntityChangeType::SettingOfTaskVehicleTempAction) { - uint16_t unk2 = buffer->Read(13); + uint16_t ped_id = buffer->Read(13); uint32_t action = buffer->Read(8); if ((action >= 15 && action <= 18) || action == 33) @@ -321,7 +321,7 @@ namespace big if (type == WorldStateDataType::Rope) { - buffer->Read(9); // unk + buffer->Read(9); // network rope id buffer->Read(19); // pos x buffer->Read(19); // pos y buffer->Read(19); // pos z @@ -342,11 +342,11 @@ namespace big } else if (type == WorldStateDataType::PopGroupOverride) { - int unk = buffer->ReadSigned(8); - int unk2 = buffer->Read(32); - int unk3 = buffer->Read(7); + int pop_schedule = buffer->ReadSigned(8); // Pop Schedule + int pop_group = buffer->Read(32); // Pop Group + int percentage = buffer->Read(7); // Percentage - if (unk2 == 0 && (unk3 == 0 || unk3 == 103)) + if (pop_group == 0 && (percentage == 0 || percentage == 103)) { notify::crash_blocked(source_player, "pop group override"); g_pointers->m_send_event_ack(event_manager, source_player, target_player, event_index, event_handled_bitset); @@ -397,7 +397,7 @@ namespace big { uint32_t timestamp = buffer->Read(32); int count = buffer->Read(2); - bool unk = buffer->Read(1); + bool all_objects_migrate_together = buffer->Read(1); if (count > 3) { @@ -408,7 +408,7 @@ namespace big { int net_id = buffer->Read(13); eNetObjType object_type = buffer->Read(4); - int unk = buffer->Read(3); + int migration_type = buffer->Read(3); if (object_type < eNetObjType::NET_OBJ_TYPE_AUTOMOBILE || object_type > eNetObjType::NET_OBJ_TYPE_TRAIN) {