refactor(PlayerDB): Improve code (#1313)

This PR includes some improvements to the player DB service:
 - Added `Get Gamer Online State` function pointer
 - Added sorting of players alphabetically and grouping of players by their online state
 - The player DB service will now update 32 players at a time for their online state
 - Player entries will automatically save when changing any data from them
 - Update the player online states every 5min

src/core/globals.hpp

@@ -213,6 +213,13 @@ namespace big
 			NLOHMANN_DEFINE_TYPE_INTRUSIVE(player, character_slot, spectating)
 		} player{};
 
+		struct player_db
+		{
+			bool update_player_online_states = false;
+
+			NLOHMANN_DEFINE_TYPE_INTRUSIVE(player_db, update_player_online_states)
+		} player_db{};
+
 		struct protections
 		{
 			struct script_events
@@ -862,7 +869,7 @@ namespace big
 			NLOHMANN_DEFINE_TYPE_INTRUSIVE(stat_editor, stat, packed_stat)
 		} stat_editor{};
 
-		NLOHMANN_DEFINE_TYPE_INTRUSIVE(menu_settings, debug, tunables, notifications, player, protections, self, session, settings, spawn_vehicle, clone_pv, spoofing, vehicle, weapons, window, context_menu, esp, session_browser, ugc, reactions, world, stat_editor)
+		NLOHMANN_DEFINE_TYPE_INTRUSIVE(menu_settings, debug, tunables, notifications, player, player_db, protections, self, session, settings, spawn_vehicle, clone_pv, spoofing, vehicle, weapons, window, context_menu, esp, session_browser, ugc, reactions, world, stat_editor)
 	};
 
 	inline auto g = menu_settings();

src/function_types.hpp

@@ -91,6 +91,7 @@ namespace big::functions
 	using fipackfile_mount   = bool (*)(rage::fiPackfile* this_, const char* mount_point);
 	using fipackfile_unmount = bool (*)(const char* mount_point);
 
+	using get_gamer_online_state = bool (*)(int profile_index, rage::rlGamerHandle* handles, std::uint32_t count, int* online_state, rage::rlTaskStatus* status);
 	using start_get_session_by_gamer_handle = bool (*)(int profile_index, rage::rlGamerHandle* handles, int count, rage::rlSessionByGamerTaskResult* result, int unk, bool* success, rage::rlTaskStatus* state);
 	using start_matchmaking_find_sessions   = bool (*)(int profile_index, int available_slots, NetworkGameFilterMatchmakingComponent* m_filter, unsigned int max_sessions, rage::rlSessionInfo* result_sessions, int* result_session_count, rage::rlTaskStatus* state);
 	using start_get_presence_attributes     = bool (*)(int profile_index, rage::rlScHandle* handle, rage::rlQueryPresenceAttributesContext* contexts, int count, rage::rlTaskStatus* state);

src/gta_pointers.hpp

@@ -141,6 +141,7 @@ namespace big
 
 		Network** m_network;
 
+		functions::get_gamer_online_state m_get_gamer_online_state;
 		functions::start_get_session_by_gamer_handle m_start_get_session_by_gamer_handle;
 		functions::start_matchmaking_find_sessions m_start_matchmaking_find_sessions;
 		functions::join_session_by_info m_join_session_by_info;

src/gui/components/components.hpp

@@ -60,16 +60,22 @@ namespace big
 		}
 
 		template<template_str cmd_str>
-		static void command_checkbox(std::optional<const std::string_view> label_override = std::nullopt)
+		static bool command_checkbox(std::optional<const std::string_view> label_override = std::nullopt)
 		{
 			static bool_command* command = dynamic_cast<bool_command*>(command::get(rage::consteval_joaat(cmd_str.value)));
 			if (command == nullptr)
-				return ImGui::Text("INVALID COMMAND");
+			{
+				ImGui::Text("INVALID COMMAND");
+				return false;
+			}
 
-			if (ImGui::Checkbox(label_override.value_or(command->get_label()).data(), &command->is_enabled()))
+			bool updated;
+			if (updated = ImGui::Checkbox(label_override.value_or(command->get_label()).data(), &command->is_enabled()))
 				command->refresh();
 			if (ImGui::IsItemHovered())
 				ImGui::SetTooltip(command->get_description().c_str());
+
+			return updated;
 		}
 
 		template<ImVec2 size = ImVec2(0, 0), ImVec4 color = ImVec4(0.24f, 0.23f, 0.29f, 1.00f)>

src/main.cpp

@@ -135,6 +135,8 @@ BOOL APIENTRY DllMain(HMODULE hmod, DWORD reason, PVOID)
 				    LOG(INFO) << "Dynamic native hooker initialized.";
 
 				    g_running = true;
+					// start update loop after setting g_running to true to prevent it from exiting instantly
+					g_player_database_service->start_update_loop();
 
 				    while (g_running)
 					    std::this_thread::sleep_for(500ms);

src/pointers.cpp

@@ -589,6 +589,15 @@ namespace big
                 g_pointers->m_gta.m_send_chat_message = ptr.sub(21).as<functions::send_chat_message>();
             }
         },
+        // Get Gamer Online State
+        {
+            "GGOS",
+            "48 8B 44 24 70 44 8B CD 4D 8B C6 41 8B D7 48 8B CF 48 89 47 40",
+            [](memory::handle ptr)
+            {
+                g_pointers->m_gta.m_get_gamer_online_state = ptr.sub(0x40).as<functions::get_gamer_online_state>();
+            }
+        },
         // Start Get Session By Gamer Handle
         {
             "SGSBGH",

src/services/player_database/persistent_player.hpp

@@ -4,6 +4,37 @@
 
 #include <unordered_set>
 
+namespace nlohmann
+{
+	template<typename T>
+	struct adl_serializer<std::optional<T>>
+	{
+		static void to_json(json& j, const std::optional<big::CommandAccessLevel>& opt)
+		{
+			if (opt == std::nullopt)
+			{
+				j = nullptr;
+			}
+			else
+			{
+				j = *opt;
+			}
+		}
+
+		static void from_json(const json& j, std::optional<big::CommandAccessLevel>& opt)
+		{
+			if (j.is_null())
+			{
+				opt = std::nullopt;
+			}
+			else
+			{
+				opt = j.get<big::CommandAccessLevel>();
+			}
+		}
+	};
+}
+
 namespace big
 {
 	enum class PlayerOnlineStatus
@@ -23,31 +54,8 @@ namespace big
 		std::unordered_set<int> infractions;
 		std::optional<CommandAccessLevel> command_access_level = std::nullopt;
 		PlayerOnlineStatus online_state                        = PlayerOnlineStatus::UNKNOWN;
+
+		NLOHMANN_DEFINE_TYPE_INTRUSIVE_WITH_DEFAULT(persistent_player, name, rockstar_id, block_join, block_join_reason, is_modder, infractions, command_access_level)
 	};
 
-	static void to_json(nlohmann::json& j, const persistent_player& player)
-	{
-		j = nlohmann::json{{"name", player.name},
-		    {"rockstar_id", player.rockstar_id},
-		    {"block_join", player.block_join},
-		    {"block_join_reason", player.block_join_reason},
-		    {"is_modder", player.is_modder},
-		    {"infractions", player.infractions}};
-
-		if (player.command_access_level.has_value())
-			j["command_access_level"] = player.command_access_level.value();
-	};
-
-	static void from_json(const nlohmann::json& j, persistent_player& player)
-	{
-		set_from_key_or_default(j, "name", player.name);
-		set_from_key_or_default(j, "rockstar_id", player.rockstar_id);
-		set_from_key_or_default(j, "block_join", player.block_join);
-		set_from_key_or_default(j, "block_join_reason", player.block_join_reason);
-		set_from_key_or_default(j, "is_modder", player.is_modder);
-		set_from_key_or_default(j, "infractions", player.infractions);
-
-		if (j.contains("command_access_level") && j["command_access_level"].is_string())
-			player.command_access_level = j["command_access_level"].get<CommandAccessLevel>();
-	}
 };

src/services/player_database/player_database_service.cpp

@@ -1,11 +1,15 @@
 #include "player_database_service.hpp"
 
+#include "backend/bool_command.hpp"
 #include "file_manager.hpp"
 #include "pointers.hpp"
 #include "util/session.hpp"
 
 namespace big
 {
+	bool_command g_player_db_auto_update_online_states("player_db_auto_update_states", "Auto Update Player Online States", "Toggling this feature will automatically update the player online states every 5minutes.",
+	    g.player_db.update_player_online_states);
+
 	player_database_service::player_database_service() :
 	    m_file_path(g_file_manager->get_project_file("./players.json").get_path())
 	{
@@ -42,35 +46,61 @@ namespace big
 			file_stream >> json;
 			file_stream.close();
 
-			for (auto& p : json.items())
+			for (auto& [key, value] : json.items())
 			{
-				m_players[std::stoll(p.key())] = p.value().get<persistent_player>();
+				auto player                = value.get<std::shared_ptr<persistent_player>>();
+				m_players[std::stoll(key)] = player;
+
+				std::string lower = player->name;
+				std::transform(lower.begin(), lower.end(), lower.begin(), ::tolower);
+				m_sorted_players[lower] = player;
 			}
 		}
 	}
 
-	std::unordered_map<std::uint64_t, persistent_player>& player_database_service::get_players()
+	std::unordered_map<std::uint64_t, std::shared_ptr<persistent_player>>& player_database_service::get_players()
 	{
 		return m_players;
 	}
 
-	persistent_player* player_database_service::get_player_by_rockstar_id(std::uint64_t rockstar_id)
+	std::map<std::string, std::shared_ptr<persistent_player>>& player_database_service::get_sorted_players()
+	{
+		return m_sorted_players;
+	}
+
+	std::shared_ptr<persistent_player> player_database_service::add_player(std::int64_t rid, const std::string_view name)
+	{
+		std::string lower = name.data();
+		std::transform(lower.begin(), lower.end(), lower.begin(), ::tolower);
+		if (m_players.contains(rid))
+		{
+			m_sorted_players.erase(lower);
+		}
+
+		auto player    = std::make_shared<persistent_player>(name.data(), rid);
+		m_players[rid] = player;
+
+		m_sorted_players[lower] = player;
+
+		return player;
+	}
+
+	std::shared_ptr<persistent_player> player_database_service::get_player_by_rockstar_id(std::uint64_t rockstar_id)
 	{
 		if (m_players.contains(rockstar_id))
-			return &m_players[rockstar_id];
+			return m_players[rockstar_id];
 		return nullptr;
 	}
 
-	persistent_player* player_database_service::get_or_create_player(player_ptr player)
+	std::shared_ptr<persistent_player> player_database_service::get_or_create_player(player_ptr player)
 	{
 		if (m_players.contains(player->get_net_data()->m_gamer_handle.m_rockstar_id))
-			return &m_players[player->get_net_data()->m_gamer_handle.m_rockstar_id];
+			return m_players[player->get_net_data()->m_gamer_handle.m_rockstar_id];
 		else
 		{
-			m_players[player->get_net_data()->m_gamer_handle.m_rockstar_id] = {player->get_name(),
+			auto player_ptr = add_player(player->get_net_data()->m_gamer_handle.m_rockstar_id, player->get_name());
-			    player->get_net_data()->m_gamer_handle.m_rockstar_id};
 			save();
-			return &m_players[player->get_net_data()->m_gamer_handle.m_rockstar_id];
+			return player_ptr;
 		}
 	}
 
@@ -87,15 +117,22 @@ namespace big
 		if (m_selected && m_selected->rockstar_id == rockstar_id)
 			m_selected = nullptr;
 
-		m_players.erase(rockstar_id);
+		if (auto it = m_players.find(rockstar_id); it != m_players.end())
+		{
+			std::string lower = it->second->name;
+			std::transform(lower.begin(), lower.end(), lower.begin(), ::tolower);
+
+			m_sorted_players.erase(lower);
+			m_players.erase(it);
+		}
 	}
 
-	void player_database_service::set_selected(persistent_player* selected)
+	void player_database_service::set_selected(std::shared_ptr<persistent_player> selected)
 	{
 		m_selected = selected;
 	}
 
-	persistent_player* player_database_service::get_selected()
+	std::shared_ptr<persistent_player> player_database_service::get_selected()
 	{
 		return m_selected;
 	}
@@ -103,35 +140,70 @@ namespace big
 	void player_database_service::invalidate_player_states()
 	{
 		for (auto& item : m_players)
-			item.second.online_state = PlayerOnlineStatus::UNKNOWN;
+			item.second->online_state = PlayerOnlineStatus::UNKNOWN;
+	}
+
+	void player_database_service::start_update_loop()
+	{
+		if (!g.player_db.update_player_online_states)
+			return;
+
+		g_thread_pool->push([this] {
+			static auto last_update = std::chrono::high_resolution_clock::now() - 5min;
+			while (g_running && g.player_db.update_player_online_states)
+			{
+				const auto cur = std::chrono::high_resolution_clock::now();
+				if (cur - last_update > 5min)
+				{
+					g_fiber_pool->queue_job([this] {
+						update_player_states();
+					});
+					last_update = cur;
+				}
+
+				std::this_thread::sleep_for(1s);
+			}
+		});
 	}
 
 	void player_database_service::update_player_states()
 	{
 		invalidate_player_states();
+		const auto player_count = m_players.size();
 
-		//fetch current stat for each player.. this will need some time.
+		std::vector<std::vector<rage::rlGamerHandle>> gamer_handle_buckets;
-		for (auto& item : m_players)
+		gamer_handle_buckets.resize(std::ceil(player_count / 32.f));
-		{
-			auto& player = item.second;
-			rage::rlGamerHandle player_handle(player.rockstar_id);
-			rage::rlSessionByGamerTaskResult result;
-			bool success = false;
-			rage::rlTaskStatus state{};
 
-			if (g_pointers->m_gta.m_start_get_session_by_gamer_handle(0, &player_handle, 1, &result, 1, &success, &state))
+		auto it = m_players.begin();
+		for (size_t i = 0; i < player_count; ++i)
+		{
+			gamer_handle_buckets[i / 32].push_back(it->second->rockstar_id);
+
+			it++;
+		}
+
+		for (auto& bucket : gamer_handle_buckets)
+		{
+			rage::rlTaskStatus status;
+			std::array<int, 32> online;
+
+			if (g_pointers->m_gta.m_get_gamer_online_state(0, bucket.data(), bucket.size(), online.data(), &status))
+			{
+				while (status.status == 1)
 				{
-				while (state.status == 1)
 					script::get_current()->yield();
+				}
 
-				if (state.status == 3 && success)
+				for (size_t i = 0; i < bucket.size(); ++i)
 				{
-					player.online_state = PlayerOnlineStatus::ONLINE;
+					if (const auto& it = m_players.find(bucket[i].m_rockstar_id); it != m_players.end())
-					continue;
+					{
-				}
+						it->second->online_state = PlayerOnlineStatus::OFFLINE;
-			}
+						if (online[i] == 1)
-
+							it->second->online_state = PlayerOnlineStatus::ONLINE;
-			player.online_state = PlayerOnlineStatus::OFFLINE;
+					}
+				}
+			}
 		}
 	}
 }

src/services/player_database/player_database_service.hpp

@@ -2,12 +2,31 @@
 #include "persistent_player.hpp"
 #include "services/players/player.hpp"
 
+namespace nlohmann
+{
+	template<typename T>
+	struct adl_serializer<std::shared_ptr<T>>
+	{
+		static void to_json(json& j, const std::shared_ptr<T>& value)
+		{
+			j = *value;
+		}
+
+		static void from_json(const json& j, std::shared_ptr<T>& value)
+		{
+			value = std::make_shared<T>();
+			*value = j.get<T>();
+		}
+	};
+}
+
 namespace big
 {
 	class player_database_service
 	{
-		std::unordered_map<std::uint64_t, persistent_player> m_players;
+		std::unordered_map<std::uint64_t, std::shared_ptr<persistent_player>> m_players;
-		persistent_player* m_selected = nullptr;
+		std::map<std::string, std::shared_ptr<persistent_player>> m_sorted_players;
+		std::shared_ptr<persistent_player> m_selected = nullptr;
 
 	public:
 		std::filesystem::path m_file_path;
@@ -17,15 +36,18 @@ namespace big
 		void save();
 		void load();
 
-		std::unordered_map<std::uint64_t, persistent_player>& get_players();
+		std::shared_ptr<persistent_player> add_player(std::int64_t rid, const std::string_view name);
-		persistent_player* get_player_by_rockstar_id(std::uint64_t rockstar_id);
+		std::unordered_map<std::uint64_t, std::shared_ptr<persistent_player>>& get_players();
-		persistent_player* get_or_create_player(player_ptr player);
+		std::map<std::string, std::shared_ptr<persistent_player>>& get_sorted_players();
+		std::shared_ptr<persistent_player> get_player_by_rockstar_id(std::uint64_t rockstar_id);
+		std::shared_ptr<persistent_player> get_or_create_player(player_ptr player);
 		void update_rockstar_id(std::uint64_t old, std::uint64_t _new);
 		void remove_rockstar_id(std::uint64_t rockstar_id);
 
-		void set_selected(persistent_player* selected);
+		void set_selected(std::shared_ptr<persistent_player> selected);
-		persistent_player* get_selected();
+		std::shared_ptr<persistent_player> get_selected();
 		
+		void start_update_loop();
 		void update_player_states();
 		void invalidate_player_states();
 	};

src/views/network/view_player_database.cpp

@@ -11,38 +11,22 @@
 
 namespace big
 {
-	persistent_player current_player;
+	char name_buf[32];
+	char search[64];
+	std::shared_ptr<persistent_player> current_player;
 
-	void view::player_database()
+	void draw_player_db_entry(std::shared_ptr<persistent_player> player, const std::string& lower_search)
 	{
-		static char name_buf[32];
+		std::string name = player->name;
-		static char search[64];
-
-		ImGui::SetNextItemWidth(300.f);
-		components::input_text_with_hint("PLAYER"_T, "SEARCH"_T, search, sizeof(search), ImGuiInputTextFlags_None);
-
-		if (ImGui::ListBoxHeader("###players", {180, static_cast<float>(*g_pointers->m_gta.m_resolution_y - 400 - 38 * 4)}))
-		{
-			auto& item_arr = g_player_database_service->get_players();
-			if (item_arr.size() > 0)
-			{
-				std::string lower_search = search;
-				std::transform(lower_search.begin(), lower_search.end(), lower_search.begin(), tolower);
-
-				for (auto& item : item_arr)
-				{
-					auto& player = item.second;
-
-					std::string name = player.name;
 		std::transform(name.begin(), name.end(), name.begin(), ::tolower);
 
 		if (lower_search.empty() || name.find(lower_search) != std::string::npos)
 		{
-						ImGui::PushID(item.first);
+			ImGui::PushID(player->rockstar_id);
 
 			float circle_size = 7.5f;
 			auto cursor_pos   = ImGui::GetCursorScreenPos();
-						auto plyr_state   = player.online_state;
+			auto plyr_state   = player->online_state;
 
 			//render status circle
 			ImGui::GetWindowDrawList()->AddCircleFilled(ImVec2(cursor_pos.x + 4.f + circle_size, cursor_pos.y + 4.f + circle_size),
@@ -56,16 +40,42 @@ namespace big
 			ImVec2 cursor = ImGui::GetCursorPos();
 			ImGui::SetCursorPos(ImVec2(cursor.x + 25.f, cursor.y));
 
-						if (components::selectable(player.name, &player == g_player_database_service->get_selected()))
+			if (components::selectable(player->name, player == g_player_database_service->get_selected()))
 			{
-							g_player_database_service->set_selected(&player);
+				g_player_database_service->set_selected(player);
 				current_player = player;
-							strncpy(name_buf, current_player.name.data(), sizeof(name_buf));
+				strncpy(name_buf, current_player->name.data(), sizeof(name_buf));
 			}
 
 			ImGui::PopID();
 		}
 	}
+
+	void view::player_database()
+	{
+
+		ImGui::SetNextItemWidth(300.f);
+		components::input_text_with_hint("PLAYER"_T, "SEARCH"_T, search, sizeof(search), ImGuiInputTextFlags_None);
+
+		if (ImGui::ListBoxHeader("###players", {180, static_cast<float>(*g_pointers->m_gta.m_resolution_y - 400 - 38 * 4)}))
+		{
+			auto& item_arr = g_player_database_service->get_sorted_players();
+			if (item_arr.size() > 0)
+			{
+				std::string lower_search = search;
+				std::transform(lower_search.begin(), lower_search.end(), lower_search.begin(), tolower);
+
+				for (auto& player : item_arr | std::ranges::views::values)
+				{
+					if (player->online_state == PlayerOnlineStatus::ONLINE)
+						draw_player_db_entry(player, lower_search);
+				}
+
+				for (auto& player : item_arr | std::ranges::views::values)
+				{
+					if (player->online_state != PlayerOnlineStatus::ONLINE)
+						draw_player_db_entry(player, lower_search);
+				}
 			}
 			else
 			{
@@ -82,23 +92,27 @@ namespace big
 			{
 				if (ImGui::InputText("NAME"_T.data(), name_buf, sizeof(name_buf)))
 				{
-					current_player.name = name_buf;
+					current_player->name = name_buf;
 				}
 
-				ImGui::InputScalar("RID"_T.data(), ImGuiDataType_S64, &current_player.rockstar_id);
+				if (ImGui::InputScalar("RID"_T.data(), ImGuiDataType_S64, &current_player->rockstar_id) || ImGui::Checkbox("IS_MODDER"_T.data(), &current_player->is_modder) || ImGui::Checkbox("BLOCK_JOIN"_T.data(), &current_player->block_join))
-				ImGui::Checkbox("IS_MODDER"_T.data(), &current_player.is_modder);
+				{
-				ImGui::Checkbox("BLOCK_JOIN"_T.data(), &current_player.block_join);
+					if (current_player->rockstar_id != selected->rockstar_id)
+						g_player_database_service->update_rockstar_id(selected->rockstar_id, current_player->rockstar_id);
+					g_player_database_service->save();
+				}
 
-				if (ImGui::BeginCombo("BLOCK_JOIN_ALERT"_T.data(), block_join_reasons[current_player.block_join_reason]))
+				if (ImGui::BeginCombo("BLOCK_JOIN_ALERT"_T.data(), block_join_reasons[current_player->block_join_reason]))
 				{
 					for (const auto& reason : block_join_reasons)
 					{
-						if (ImGui::Selectable(reason.second, reason.first == current_player.block_join_reason))
+						if (ImGui::Selectable(reason.second, reason.first == current_player->block_join_reason))
 						{
-							current_player.block_join_reason = reason.first;
+							current_player->block_join_reason = reason.first;
+							g_player_database_service->save();
 						}
 
-						if (reason.first == current_player.block_join_reason)
+						if (reason.first == current_player->block_join_reason)
 						{
 							ImGui::SetItemDefaultFocus();
 						}
@@ -112,16 +126,17 @@ namespace big
 
 
 				if (ImGui::BeginCombo("CHAT_COMMAND_PERMISSIONS"_T.data(),
-				        COMMAND_ACCESS_LEVELS[current_player.command_access_level.value_or(g.session.chat_command_default_access_level)]))
+				        COMMAND_ACCESS_LEVELS[current_player->command_access_level.value_or(g.session.chat_command_default_access_level)]))
 				{
 					for (const auto& [type, name] : COMMAND_ACCESS_LEVELS)
 					{
-						if (ImGui::Selectable(name, type == current_player.command_access_level.value_or(g.session.chat_command_default_access_level)))
+						if (ImGui::Selectable(name, type == current_player->command_access_level.value_or(g.session.chat_command_default_access_level)))
 						{
-							current_player.command_access_level = type;
+							current_player->command_access_level = type;
+							g_player_database_service->save();
 						}
 
-						if (type == current_player.command_access_level.value_or(g.session.chat_command_default_access_level))
+						if (type == current_player->command_access_level.value_or(g.session.chat_command_default_access_level))
 						{
 							ImGui::SetItemDefaultFocus();
 						}
@@ -130,18 +145,18 @@ namespace big
 					ImGui::EndCombo();
 				}
 
-				if (!current_player.infractions.empty())
+				if (!current_player->infractions.empty())
 				{
 					ImGui::Text("INFRACTIONS"_T.data());
 
-					for (auto& infraction : current_player.infractions)
+					for (auto& infraction : current_player->infractions)
 					{
 						ImGui::BulletText(infraction_desc[(Infraction)infraction]);
 					}
 				}
 
 				components::button("JOIN_SESSION"_T, [] {
-					session::join_by_rockstar_id(current_player.rockstar_id);
+					session::join_by_rockstar_id(current_player->rockstar_id);
 				});
 
 				static char message[256];
@@ -160,10 +175,10 @@ namespace big
 
 				if (ImGui::Button("SAVE"_T.data()))
 				{
-					if (current_player.rockstar_id != selected->rockstar_id)
+					if (current_player->rockstar_id != selected->rockstar_id)
-						g_player_database_service->update_rockstar_id(selected->rockstar_id, current_player.rockstar_id);
+						g_player_database_service->update_rockstar_id(selected->rockstar_id, current_player->rockstar_id);
 
-					*selected = current_player;
+					selected = current_player;
 					g_player_database_service->save();
 				}
 
@@ -181,6 +196,7 @@ namespace big
 		{
 			g_player_database_service->set_selected(nullptr);
 			g_player_database_service->get_players().clear();
+			g_player_database_service->get_sorted_players().clear();
 			g_player_database_service->save();
 		}
 
@@ -190,6 +206,9 @@ namespace big
 			g_player_database_service->update_player_states();
 		});
 
+		if (components::command_checkbox<"player_db_auto_update_states">())
+			g_player_database_service->start_update_loop();
+
 		ImGui::Separator();
 		components::sub_title("NEW_ENTRY"_T);
 
@@ -201,7 +220,7 @@ namespace big
 
 		if (ImGui::Button("ADD"_T.data()))
 		{
-			g_player_database_service->get_players()[new_rockstar_id] = persistent_player(new_name, new_rockstar_id);
+			current_player = g_player_database_service->add_player(new_rockstar_id, new_name);
 			g_player_database_service->save();
 		}
 	}