ModdingRX/YimMenu
Archived
1
0
Fork 0
Code Actions Releases Activity

fix(lua): fix script array iterator being potentially invalidated while iterating due to new scripts that could be added and the vector getting reallocated due to it. (#1883)

Browse Source
This commit is contained in:
Quentin 2023-07-29 11:22:04 +02:00 committed by GitHub
parent b48c256954
commit c54be57469
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/lua/lua_module.cpp
View File

@ -231,8 +231,11 @@ namespace big
{ {
std::lock_guard guard(m_registered_scripts_mutex); std::lock_guard guard(m_registered_scripts_mutex);
for (auto& script : m_registered_scripts) const auto script_count = m_registered_scripts.size();
for (size_t i = 0; i < script_count; i++)
{ {
const auto script = m_registered_scripts[i].get();
if (script->is_enabled()) if (script->is_enabled())
{ {
script->tick(); script->tick();