changes

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,12 +1,12 @@
 name: Bug report
 description: Report a *specific* issue
-title: "[Bug]: "
+title: "[Bug]: <Enter descriptive title here>"
 labels: bug
 body:
   - type: textarea
     attributes:
       label: Describe the bug
-      description: A clear and concise description of what the bug is. If you want to ask a general question about the menu, please open a new Discussion instead
+      description: A clear and concise description of what the bug is. If you want to ask a general question about the menu, please open a new Discussion instead. I repeat, if this is NOT A BUG WITH THE MENU, do not open a bug report
     validations:
       required: true
   - type: textarea
@@ -32,6 +32,7 @@ body:
       description: |
         For a bug report to be valid, please include the logs for YimMenuV2.
         They can be found under `%appdata%/YimMenuV2/cout.log`, even if you think the log file is useless we'd still like for you to include it here.
+        You MUST do this if you're reporting a crash. Attaching the DLL you used is also helpful
 
         Tip: You can attach images or log files by clicking this area to highlight it and then dragging files in.
       value: |
@@ -49,6 +50,7 @@ body:
         - Steam
         - Epic Games
         - Rockstar
+        - Microsoft Store/Game Pass
         - Other (please mention in "Additional context")
     validations:
       required: true

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -1,12 +1,12 @@
 name: Feature request
 description: Suggest an idea for this project
-title: "[Request]: "
+title: "[Request]: <Enter descriptive title here>"
 labels: request
 body:
   - type: textarea
     attributes:
       label: Problem
-      description: "Is your feature request related to a problem? Please describe."
+      description: "Is your feature request related to a problem? Please describe. This is not Discord; please use proper capitalization and punctuation when creating feature requests"
       placeholder: "A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]"
     validations:
       required: false

CONTRIBUTING.md

@@ -1,6 +1,18 @@
 # YimMenu Contribution Guide (WIP)
 
+## Important!
+
+PRs containing AI-generated code will NOT BE ACCEPTED! 
+
 ## Structure
 
 - `core/` : Essential general features for the base
-- `game/` : Game specific implemented things
+- `game/` : Game specific implemented things
+
+## General tips
+
+- Try to use Clang instead of MSVC and fix all compiler warnings
+- All new features should be implemented as `Command`s. gta/features/self/Suicide.cpp contains an example of a normal `Command`, and gta/features/self/Godmode.cpp contains a `LoopedCommand` (a command that runs every frame)
+- When constructing constexpr arrays, make sure to use `std::to_array` instead of relying on automatic deduction in order to prevent issues when building with Clang
+- Use `static_cast` and `reinterpret_cast` instead of C-style casts
+- Use `std::string_view` for immutable string parameters

src/core/frontend/widgets/imgui_bitfield.hpp

@@ -60,7 +60,7 @@ namespace ImGui
 			}
 			if (i % 4 == 0)
 			{
-				ImGui::Text("%i", i);
+				ImGui::Text("%lld", i);
 				ImGui::EndGroup();
 			}
 			if (i % 16 != 0)

src/game/frontend/submenus/Debug/Scripts.cpp

@@ -85,8 +85,8 @@ namespace YimMenu::Submenus
 
 			ImGui::Text("Thread ID: %d", curThread->m_Context.m_ThreadId);
 			ImGui::Text("Stack Size: %d", curThread->m_Context.m_StackSize);
-			ImGui::Text("Stack Pointer: 0x%X", &curThread->m_Context.m_StackPointer);
-			ImGui::Text("Program Counter: 0x%X", &curThread->m_Context.m_ProgramCounter); // This is not really accurate (always points to the WAIT)
+			ImGui::Text("Stack Pointer: 0x%p", &curThread->m_Context.m_StackPointer);
+			ImGui::Text("Program Counter: 0x%p", &curThread->m_Context.m_ProgramCounter); // This is not really accurate (always points to the WAIT)
 			if (curThread->m_Context.m_State == rage::scrThread::State::KILLED)
 				ImGui::Text("Exit Reason: %s", curThread->m_ErrorMessage);
 		}));

src/game/gta/data/ScriptNames.hpp

@@ -2,7 +2,7 @@
 
 namespace YimMenu
 {
-	static constexpr std::array scriptNames = {
+	static constexpr auto scriptNames = std::to_array({
 	    "abigail1",
 	    "abigail2",
 	    "achievement_controller",
@@ -1103,5 +1103,5 @@ namespace YimMenu
 	    "wp_partyboombox",
 	    "xml_menus",
 	    "yoga"
-	};
+	});
 }