Backups/OpenList
1
0
Fork 0
mirror of https://github.com/OpenListTeam/OpenList.git synced 2025-09-19 12:16:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(189pc): crashes when upload cancelled (#79)

Browse Source 
* fix(189pc): crashes when upload cancelled

Signed-off-by: XZB-1248 <28593573+XZB-1248@users.noreply.github.com>

* fix(189pc): replace semaphore with errgroup.Group.SetLimit

---------

Signed-off-by: XZB-1248 <28593573+XZB-1248@users.noreply.github.com>
Co-authored-by: KirCute <951206789@qq.com>
This commit is contained in:
XZB-1248
2025-06-17 00:13:31 +08:00
committed by GitHub
parent 5a4649c929
commit 87ca1b96ae
5 changed files with 12 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/driver/driver.go
View File

@ -97,9 +97,9 @@ type Put interface {
// before uploading the file or file chunks. Or you can directly call `driver.ServerUploadLimitWaitN`
// if your file chunks are sufficiently small (less than about 50KB).
// NOTE that the network speed may be significantly slower than the stream's read speed. Therefore, if
// you use a `errgroup.Group` to upload each chunk in parallel, you should consider using a recursive
// mutex like `semaphore.Weighted` to limit the maximum number of upload threads, preventing excessive
// memory usage caused by buffering too many file chunks awaiting upload.
// you use a `errgroup.Group` to upload each chunk in parallel, you should use `Group.SetLimit` to
// limit the maximum number of upload threads, preventing excessive memory usage caused by buffering
// too many file chunks awaiting upload.
Put(ctx context.Context, dstDir model.Obj, file model.FileStreamer, up UpdateProgress) error
}
@ -156,9 +156,9 @@ type PutResult interface {
// before uploading the file or file chunks. Or you can directly call `driver.ServerUploadLimitWaitN`
// if your file chunks are sufficiently small (less than about 50KB).
// NOTE that the network speed may be significantly slower than the stream's read speed. Therefore, if
// you use a `errgroup.Group` to upload each chunk in parallel, you should consider using a recursive
// mutex like `semaphore.Weighted` to limit the maximum number of upload threads, preventing excessive
// memory usage caused by buffering too many file chunks awaiting upload.
// you use a `errgroup.Group` to upload each chunk in parallel, you should use `Group.SetLimit` to
// limit the maximum number of upload threads, preventing excessive memory usage caused by buffering
// too many file chunks awaiting upload.
Put(ctx context.Context, dstDir model.Obj, file model.FileStreamer, up UpdateProgress) (model.Obj, error)
}