From bdda12a040af59be0626c58c0367acd3318b7f87 Mon Sep 17 00:00:00 2001 From: Sinai <49360850+sinai-dev@users.noreply.github.com> Date: Fri, 22 Apr 2022 09:08:17 +1000 Subject: [PATCH] Remove redundant reference to EvaluateWidget --- src/UI/Widgets/EvaluateWidget/BaseArgumentHandler.cs | 2 -- src/UI/Widgets/EvaluateWidget/EvaluateWidget.cs | 4 ++-- src/UI/Widgets/EvaluateWidget/GenericArgumentHandler.cs | 4 +--- src/UI/Widgets/EvaluateWidget/ParameterHandler.cs | 4 +--- 4 files changed, 4 insertions(+), 10 deletions(-) diff --git a/src/UI/Widgets/EvaluateWidget/BaseArgumentHandler.cs b/src/UI/Widgets/EvaluateWidget/BaseArgumentHandler.cs index 6cf7df2..a8b3873 100644 --- a/src/UI/Widgets/EvaluateWidget/BaseArgumentHandler.cs +++ b/src/UI/Widgets/EvaluateWidget/BaseArgumentHandler.cs @@ -9,8 +9,6 @@ namespace UnityExplorer.UI.Widgets { public abstract class BaseArgumentHandler : IPooledObject { - protected EvaluateWidget evaluator; - internal Text argNameLabel; internal InputFieldRef inputField; internal TypeCompleter typeCompleter; diff --git a/src/UI/Widgets/EvaluateWidget/EvaluateWidget.cs b/src/UI/Widgets/EvaluateWidget/EvaluateWidget.cs index cb23e49..cb2aca9 100644 --- a/src/UI/Widgets/EvaluateWidget/EvaluateWidget.cs +++ b/src/UI/Widgets/EvaluateWidget/EvaluateWidget.cs @@ -110,7 +110,7 @@ namespace UnityExplorer.UI.Widgets GenericArgumentHandler holder = genericHandlers[i] = Pool.Borrow(); holder.UIRoot.transform.SetParent(this.genericArgumentsHolder.transform, false); - holder.OnBorrowed(this, type); + holder.OnBorrowed(type); } } @@ -122,7 +122,7 @@ namespace UnityExplorer.UI.Widgets ParameterHandler holder = paramHandlers[i] = Pool.Borrow(); holder.UIRoot.transform.SetParent(this.parametersHolder.transform, false); - holder.OnBorrowed(this, param); + holder.OnBorrowed(param); } } diff --git a/src/UI/Widgets/EvaluateWidget/GenericArgumentHandler.cs b/src/UI/Widgets/EvaluateWidget/GenericArgumentHandler.cs index 599f81f..899429d 100644 --- a/src/UI/Widgets/EvaluateWidget/GenericArgumentHandler.cs +++ b/src/UI/Widgets/EvaluateWidget/GenericArgumentHandler.cs @@ -9,9 +9,8 @@ namespace UnityExplorer.UI.Widgets { private Type genericType; - public void OnBorrowed(EvaluateWidget evaluator, Type genericConstraint) + public void OnBorrowed(Type genericConstraint) { - this.evaluator = evaluator; this.genericType = genericConstraint; typeCompleter.Enabled = true; @@ -39,7 +38,6 @@ namespace UnityExplorer.UI.Widgets public void OnReturned() { - this.evaluator = null; this.genericType = null; this.typeCompleter.Enabled = false; diff --git a/src/UI/Widgets/EvaluateWidget/ParameterHandler.cs b/src/UI/Widgets/EvaluateWidget/ParameterHandler.cs index b2411c0..bd92b0f 100644 --- a/src/UI/Widgets/EvaluateWidget/ParameterHandler.cs +++ b/src/UI/Widgets/EvaluateWidget/ParameterHandler.cs @@ -26,9 +26,8 @@ namespace UnityExplorer.UI.Widgets private Text basicLabel; private ButtonRef pasteButton; - public void OnBorrowed(EvaluateWidget evaluator, ParameterInfo paramInfo) + public void OnBorrowed(ParameterInfo paramInfo) { - this.evaluator = evaluator; this.paramInfo = paramInfo; this.paramType = paramInfo.ParameterType; @@ -85,7 +84,6 @@ namespace UnityExplorer.UI.Widgets public void OnReturned() { - this.evaluator = null; this.paramInfo = null; this.enumCompleter.Enabled = false;